----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73326/#review222944 -----------------------------------------------------------
intg/src/main/java/org/apache/ranger/RangerClient.java Line 457 (original), 454 (patched) <https://reviews.apache.org/r/73326/#comment312105> Please consider enclosing even a single statement in else clause inside curly brackets for readabilty and ease of maintenance. intg/src/main/java/org/apache/ranger/RangerClient.java Line 466 (original), 491 (patched) <https://reviews.apache.org/r/73326/#comment312104> Please consider if such checks are necessary in all callAPI() functions; responseHandler() call throws exception if the clientResponse is null anyway (line 461). intg/src/main/java/org/apache/ranger/RangerClient.java Lines 504 (patched) <https://reviews.apache.org/r/73326/#comment312106> How is this method different from one on line 484? Can the earlier method be used generically everwhere the class-type needs to be specified (and this method be removed)? - Abhay Kulkarni On April 30, 2021, 8:53 p.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73326/ > ----------------------------------------------------------- > > (Updated April 30, 2021, 8:53 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3227 > https://issues.apache.org/jira/browse/RANGER-3227 > > > Repository: ranger > > > Description > ------- > > Fix deserialization issues when parsing REST reponses by using GenericType. > > > Diffs > ----- > > intg/src/main/java/org/apache/ranger/RangerClient.java c7e32dc59 > > ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java > b380127bf > > > Diff: https://reviews.apache.org/r/73326/diff/1/ > > > Testing > ------- > > Tested the changes on local machine. > > > Thanks, > > Abhishek Kumar > >
