----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73367/#review223083 -----------------------------------------------------------
Fix it, then Ship it! plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java Lines 62 (patched) <https://reviews.apache.org/r/73367/#comment312223> pluginConfig is used only within init(). Consider removing this member. - Madhan Neethiraj On May 30, 2021, 7:59 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73367/ > ----------------------------------------------------------- > > (Updated May 30, 2021, 7:59 a.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3294 > https://issues.apache.org/jira/browse/RANGER-3294 > > > Repository: ranger > > > Description > ------- > > RANGER-3294:AccessResult attribute with isAudited as false not filtered in > Ranger Audit Filter > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java > 7b34f77da > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > ecfc9ad14 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 4d7fb6c87 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > 539d4c148 > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java > c5fe8a332 > > hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerHdfsAuthorizerTest.java > e96ea5c12 > hdfs-agent/src/test/resources/hdfs_version_3.0/hdfs-policies.json a3fd96813 > hdfs-agent/src/test/resources/ranger-hdfs-security.xml 2c7f22fa9 > > plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java > 1f965823c > > > Diff: https://reviews.apache.org/r/73367/diff/3/ > > > Testing > ------- > > - Verified in local VM for audit filter to filter out Allow and deny request > in Hive. > - Verified YARN and HDFS fallback and audit related to it. > - Fixed failing Unit test based on this change. > > > Thanks, > > Ramesh Mani > >
