-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73480/#review223271
-----------------------------------------------------------




plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java
Lines 159 (patched)
<https://reviews.apache.org/r/73480/#comment312350>

    We should check for null and empty in case omUser the way we do for hdfs 
user. 
    
    Also it will be good to have separate code block snippet for om users the 
way we maintian for other users.


- Dhaval Shah


On July 24, 2021, 5:57 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73480/
> -----------------------------------------------------------
> 
> (Updated July 24, 2021, 5:57 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3545
>     https://issues.apache.org/jira/browse/RANGER-3545
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Default Ranger policy for KMS should include "om" user for Ozone bucket level 
> encryption to work.
> 
> 
> Diffs
> -----
> 
>   
> plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 
> 8af592b2a 
>   security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 12eb8fe64 
> 
> 
> Diff: https://reviews.apache.org/r/73480/diff/1/
> 
> 
> Testing
> -------
> 
> Ran : mvn clean compile test verify install - Build was successful
> Testing : Performed the functional testing.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>

Reply via email to