----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73535/#review223372 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 23, 2021, 11:09 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73535/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2021, 11:09 a.m.) > > > Review request for ranger, Abhishek Kumar, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3376 > https://issues.apache.org/jira/browse/RANGER-3376 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** > Currently x_policy_change_log table has policy_id column and it does not have > its guid there. > For few operations we might need guid of the policy, if its in the same table > then it shall reduce the loopup time. > > **Proposed Solution:** > Add policy_guid column in the x_policy_change_log table for fresh and upgrade > case and update the policy_guid column value also whenever any entry is added > for a policy change event goes to the x_policy_change_log table. > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 1ba3e69e8 > > security-admin/db/mysql/patches/056-add-policyguid-in-x_policy_change_log.sql > PRE-CREATION > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 021c34c77 > > security-admin/db/oracle/patches/056-add-policyguid-in-x_policy_change_log.sql > PRE-CREATION > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 89e9e77a0 > > security-admin/db/postgres/patches/056-add-policyguid-in-x_policy_change_log.sql > PRE-CREATION > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > b90a48e0a > > security-admin/db/sqlanywhere/patches/056-add-policyguid-in-x_policy_change_log.sql > PRE-CREATION > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > 7e03289dd > > security-admin/db/sqlserver/patches/056-add-policyguid-in-x_policy_change_log.sql > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > b9a926b33 > > security-admin/src/main/java/org/apache/ranger/entity/XXPolicyChangeLog.java > bc48d4a25 > > > Diff: https://reviews.apache.org/r/73535/diff/1/ > > > Testing > ------- > > Tested the patch for fresh and upgrade case in MySQL, Oracle, PostGres, MSSQL > db flavor. > Column policy_guid was added in the x_policy_change_log table. > policy_guid values was updated for each policy change event in the > x_policy_change_log table. > > > Thanks, > > Pradeep Agrawal > >
