----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73540/#review223381 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java Lines 40 (patched) <https://reviews.apache.org/r/73540/#comment312440> RangerAccessResourceImpl is plugin-agnostic class; please avoid plugin specific flags - like hdfsResource here. For HDFS resource specific optimizations, consider overriding RangerHdfsResource.getAsString() as shown below: class RangerHdfsResource extends RangerAccessResourceImpl { ... @Override public String getAsString() { String ret = super.getStringifiedValue(); if (ret == null) { ret = Objects.toString(super.getValue(RangerHdfsAuthorizer.KEY_RESOURCE_PATH)); super.setStringifiedValue(ret); } return ret; } ... } - Madhan Neethiraj On Aug. 24, 2021, 7:47 a.m., cao zhiqiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73540/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2021, 7:47 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-3378 > https://issues.apache.org/jira/browse/RANGER-3378 > > > Repository: ranger > > > Description > ------- > > RangerAccessResourceImpl.getAsString function take too much time. We should > replace it to improve performance for hdfs. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java > 93810ae21 > > > Diff: https://reviews.apache.org/r/73540/diff/1/ > > > Testing > ------- > > The getAsString function take mush less more than before. > > > Thanks, > > cao zhiqiang > >
