-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73545/
-----------------------------------------------------------

Review request for ranger and Abhay Kulkarni.


Bugs: RANGER-3371
    https://issues.apache.org/jira/browse/RANGER-3371


Repository: ranger


Description
-------

**Problem Statement:** While saving policy object to json string, serviceType 
is not being stored with policy json.
Due to this delta policies validation(RangerPolicyDeltaUtil.isValidDeltas()) 
fails and delta policies are not returned, Since delta policy result is empty 
ranger is fetching all ranger policies.

**Proposed Solution:** Before converting policy object to json string, 
serviceType field of the policy object can be updated, so that during the 
object to json conversion serviceType field value is also added in policy json.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 
16aaf306c 
  
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java
 7ee829276 


Diff: https://reviews.apache.org/r/73545/diff/1/


Testing
-------

With patch, tested policy creation and serviceType field and its value is added 
in the policy text for the respective policy.
Further checked the delta policy and validation is passing.


Thanks,

Pradeep Agrawal

Reply via email to