----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73578/#review223487 -----------------------------------------------------------
Fix it, then Ship it! hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java Line 998 (original), 998 (patched) <https://reviews.apache.org/r/73578/#comment312561> Please consider using CollectionUtils.isEmpty(inputHObjs) && CollectionUtils.isEmpty(outputHObjs) instead of CollectionUtils.isEmpty(requests) to match code with comment. hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java Line 3220 (original), 3295 (patched) <https://reviews.apache.org/r/73578/#comment312560> Why is this made public method? - Abhay Kulkarni On Sept. 12, 2021, 6:10 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73578/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2021, 6:10 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3407 > https://issues.apache.org/jira/browse/RANGER-3407 > > > Repository: ranger > > > Description > ------- > > RANGER-3407:Handle authorization of Hive Drop database / table if exists in > RangerHiveAuthorizer when database / table doesn't exist > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > e0934de3a > > > Diff: https://reviews.apache.org/r/73578/diff/1/ > > > Testing > ------- > > - Verified commands Drop database if exists <db_name> with and without db's > presence > - Verified commands Drop table if exists <db_name.tableName> or Drop table if > exists <tableName> with and without db/tables presence. > - Behavior should same as how hive handle this commands with Ranger. > > > Thanks, > > Ramesh Mani > >
