----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73609/#review223535 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Sept. 25, 2021, 7:56 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73609/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2021, 7:56 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-3447 > https://issues.apache.org/jira/browse/RANGER-3447 > > > Repository: ranger > > > Description > ------- > > Replaced query per access-type with a single query to load implied grants for > all access-types. For service-defs with large number of access-types, avoid > large number of queries results in sizable reduction in time to read > service-def. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/db/XXAccessTypeDefGrantsDao.java > 6459bdab3 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > 4fe19c478 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 8eff33643 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java > a36b19879 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java > 74f1dd0c4 > > > Diff: https://reviews.apache.org/r/73609/diff/1/ > > > Testing > ------- > > - verified that all existing test pass successfully > - verified that implied-grants are read correctly with this change > > > Thanks, > > Madhan Neethiraj > >
