----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73633/#review223589 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java Line 223 (original), 219 (patched) <https://reviews.apache.org/r/73633/#comment312693> Please review this change. Can it simply be as follows? if (savedKey != null && !savedKey.trim().equals("")) { if (logger.isDebugEnabled()) { <<<< logger.debug("Master Key Created with id = " + savedKey); <<<< } } - Abhay Kulkarni On Oct. 7, 2021, 1:04 a.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73633/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2021, 1:04 a.m.) > > > Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-3421 > https://issues.apache.org/jira/browse/RANGER-3421 > > > Repository: ranger > > > Description > ------- > > Avoiding logging key details and code refactoring. > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java > adb2c2604 > > > Diff: https://reviews.apache.org/r/73633/diff/1/ > > > Testing > ------- > > > Thanks, > > Abhishek Kumar > >
