----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73657/#review223635 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4230 (patched) <https://reviews.apache.org/r/73657/#comment312750> Consider returning null when serviceName or policyName is null, instead of returning the first policy found. RangerPolicy ret = null; if (serviceName != null && policyName != null) { SearchFilter filter = new SearchFilter(); filter.setParam(SearchFilter.SERVICE_NAME, serviceName); filter.setParam(SearchFilter.POLICY_NAME, policyName); List<RangerPolicy> policies = getPolicies(filter); if (CollectionUtils.isNotEmpty(policies)) { ret = policies.get(0); } } - Madhan Neethiraj On Oct. 20, 2021, 4:44 a.m., Kishor Gollapalliwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73657/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2021, 4:44 a.m.) > > > Review request for ranger, Abhishek Kumar, Dineshkumar Yadav, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, and Velmurugan Periasamy. > > > Bugs: RANGER-3433 > https://issues.apache.org/jira/browse/RANGER-3433 > > > Repository: ranger > > > Description > ------- > > Null Dereference in ServiceREST getPolicyByName method > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 01e952a23 > > > Diff: https://reviews.apache.org/r/73657/diff/1/ > > > Testing > ------- > > 1. Maven build > 2. Setup Ranger Admin > 2. Create, Update & Delete policy > > > Thanks, > > Kishor Gollapalliwar > >
