> On Oct. 20, 2021, 10:18 p.m., Madhan Neethiraj wrote:
> > In addition to the changes in this patch, DB scripts need to be updated to
> > setup unique-key constraint for {service, zone, resource-signature}.
> >
> > Also, resource signature of existing disabled policies should be updated
> > using a Java patch.
>
> Abhay Kulkarni wrote:
> As zone is encrypted within policy-resource-signature, the unique-key
> constraint needs to be on {service, resource-signature } fields.
You are right. In fact, I noted the same in RANGER-3472; missed it in this
review :-)
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73659/#review223642
-----------------------------------------------------------
On Oct. 20, 2021, 7:28 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73659/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2021, 7:28 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Pradeep
> Agrawal, Ramesh Mani, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-3490
> https://issues.apache.org/jira/browse/RANGER-3490
>
>
> Repository: ranger
>
>
> Description
> -------
>
> There may be multiple policies with the same resource signature within a
> service (at most one enabled policy and potentially any number of disabled
> policies). Therefore, the resource-signature uniqueness within a service
> cannot be enforced at the database level.
>
> The proposal is to encode GUID of a disabled policy within the resource
> signature, thus making the resource signature unique within a service.
>
>
> Diffs
> -----
>
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java
> 312005e0f
>
> agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java
> bc9df31cc
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
> f13cef71d
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java
> ef0d3b4eb
>
>
> Diff: https://reviews.apache.org/r/73659/diff/1/
>
>
> Testing
> -------
>
> Compiled and ran all unit tests successfully.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
