----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73665/#review223663 -----------------------------------------------------------
@Ramesh - good to see addition of docker setup for Ranger plugins. Thank you. Couple of suggestions: - README.txt (5.2) should be updated to include Knox container build and startup - Setup Knox with at least one topology (webhdfs), to demostrate Ranger plugin in action dev-support/ranger-docker/Dockerfile.ranger-base Lines 22 (patched) <https://reviews.apache.org/r/73665/#comment312763> Since 'expect' is needed only in Knox container, consider moving its installation to Dockerfile.ranger-knox. dev-support/ranger-docker/docker-compose.ranger-knox.yml Lines 17 (patched) <https://reviews.apache.org/r/73665/#comment312764> Consider exposing the port Knox listens on with the following: ports: - "8443:8443" - Madhan Neethiraj On Oct. 21, 2021, 7:25 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73665/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2021, 7:25 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3488 > https://issues.apache.org/jira/browse/RANGER-3488 > > > Repository: ranger > > > Description > ------- > > RANGER-3488:Docker setup for Apache Ranger Knox plugin > > > Diffs > ----- > > agents-installer/pom.xml 76c2961b3 > dev-support/ranger-docker/.dockerignore e42d86501 > dev-support/ranger-docker/.env 100ed71d8 > dev-support/ranger-docker/Dockerfile.ranger 894001492 > dev-support/ranger-docker/Dockerfile.ranger-base 3fa657b80 > dev-support/ranger-docker/Dockerfile.ranger-knox PRE-CREATION > dev-support/ranger-docker/docker-compose.ranger-knox.yml PRE-CREATION > dev-support/ranger-docker/download-archives.sh e107be09b > dev-support/ranger-docker/scripts/ranger-hadoop-mkdir.sh de16245ca > dev-support/ranger-docker/scripts/ranger-knox-expect.sh PRE-CREATION > dev-support/ranger-docker/scripts/ranger-knox-plugin-install.properties > PRE-CREATION > dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py > PRE-CREATION > dev-support/ranger-docker/scripts/ranger-knox-setup.sh PRE-CREATION > dev-support/ranger-docker/scripts/ranger-knox.sh PRE-CREATION > dev-support/ranger-docker/scripts/ranger.sh 04ac7cb4b > distro/src/main/assembly/knox-agent.xml c1f16d62f > > > Diff: https://reviews.apache.org/r/73665/diff/1/ > > > Testing > ------- > > - Verified by bringing up docker image with knox in a container. > > > Thanks, > > Ramesh Mani > >
