----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73336/#review223707 -----------------------------------------------------------
Ship it! Ship It! - Abhishek Kumar On May 5, 2021, 6:24 p.m., Chia-Ping Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73336/ > ----------------------------------------------------------- > > (Updated May 5, 2021, 6:24 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-3276 > https://issues.apache.org/jira/browse/RANGER-3276 > > > Repository: ranger > > > Description > ------- > > the duplicate code are shown below. > > 1. > https://github.com/apache/ranger/blob/release-ranger-2.1.0/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java#L317 > > 2. > https://github.com/apache/ranger/blob/release-ranger-2.1.0/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java#L324 > > > Diffs > ----- > > > credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java > 5d196d972 > > > Diff: https://reviews.apache.org/r/73336/diff/1/ > > > Testing > ------- > > run `mvn clean test` on my local. all tests pass > > > Thanks, > > Chia-Ping Tsai > >
