----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73758/#review223848 -----------------------------------------------------------
Fix it, then Ship it! ranger-tools/scripts/create_tags_file.sh Lines 39 (patched) <https://reviews.apache.org/r/73758/#comment312891> ok. Thanks for the details. I suggest one change: instead of writting to same file, it might help to write a /tmp/ file and then move to output_file. ./gen_service_tags.sh cm_hive ${num_of_tags} ${initial_id} > /tmp/$$-${output_file} mv /tmp/$$-${output_file} ${output_file} This can help avoid plugin to load empty/partial file. - Madhan Neethiraj On Dec. 13, 2021, 3:53 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73758/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2021, 3:53 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-3548 > https://issues.apache.org/jira/browse/RANGER-3548 > > > Repository: ranger > > > Description > ------- > > It is useful to have scripts to create a file containing large number of > tagged entities that can be uploaded into Ranger using file-based interface > supported by tagsync. Such scripts are useful in populating a large number of > tagged entities in Ranger for testing performance/memory characteristics of > Ranger admin and the services using Ranger as an authorizer. > > > Diffs > ----- > > distro/src/main/assembly/ranger-tools.xml 1eb9104b5 > ranger-tools/scripts/create_tags_file.sh PRE-CREATION > ranger-tools/scripts/gen_service_tags.sh 9a81a0a19 > > > Diff: https://reviews.apache.org/r/73758/diff/1/ > > > Testing > ------- > > - Created a file containing tagged hive entities > - Uploaded generated file into Ranger using tagsync's file-based interface > - Ensured that the tagged entities are downloaded to hive service > > > Thanks, > > Abhay Kulkarni > >
