----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73761/#review223861 -----------------------------------------------------------
Ship it! Ship It! - bhavik patel On Dec. 15, 2021, 4:19 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73761/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2021, 4:19 p.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-3553 > https://issues.apache.org/jira/browse/RANGER-3553 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Unit test coverage for XUserMgr class need to be > increased. > > > Currently Unit Test coverage of XUserMgr is 65% > Total No. of test cases in TestXUserMgr class are: 108 > > > ** Proposed Improvement:** > Proposed patch contains lot of additional unit test cases and modification in > existing unit test cases. > > Statistics after the patch are: > Test coverage of XUserMgr after this patch will be 89% > Total No. of test cases in TestXUserMgr class will be: 132 > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 546345ac0 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 5b201ec87 > > > Diff: https://reviews.apache.org/r/73761/diff/1/ > > > Testing > ------- > > All testcases are running fine and build was successful. > > > Thanks, > > Pradeep Agrawal > >
