----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73793/#review223986 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java Line 2934 (original), 2944 (patched) <https://reviews.apache.org/r/73793/#comment313005> Can we add break statement after this line ? check the same for line 2955. ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java Lines 1050 (patched) <https://reviews.apache.org/r/73793/#comment313006> i think we should change whiteListUserRoleRules.isEmpty() to whiteListUserRoleRules.trim().isEmpty() as we are returning the trimmed value. - Pradeep Agrawal On Jan. 8, 2022, 12:13 a.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73793/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2022, 12:13 a.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, > Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-3403 > https://issues.apache.org/jira/browse/RANGER-3403 > > > Repository: ranger > > > Description > ------- > > 1. Introduced new usersync configuration to treat service users like > "rangerusersync", "admin", "rangertagsync" that require "ROLE_SYS_ADMIN" > privileges. > 2. Fixed issue where removing a role assignment rule from usersync > configuration is not updating the role of the affected users. > 3. Also fixed an issue where the role (other than “ROLE_USER”) assigned to an > external user manually from Ranger UI, is not reset automatically when > usersync is restarted. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 0eb582c8e > security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java > d383cf596 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml c19ec495e > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 945bba48d > > ugsync-util/src/main/java/org/apache/ranger/ugsyncutil/model/UsersGroupRoleAssignments.java > ce0b9dd8b > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > ea6b47cd0 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 60445043f > > > Diff: https://reviews.apache.org/r/73793/diff/1/ > > > Testing > ------- > > 1. Verified functional test cases with new configuration and existing role > assignment configuration. > 2. Verified few regression test cases with default options > 3. Verified all the existing unit test cases pass. > > > Thanks, > > Sailaja Polavarapu > >
