> On 一月 24, 2022, 11:20 a.m., Mateen Mansoori wrote: > > After applying your patch, Below files/folder are missing from ews/webaap > > > > log4j-kmsaudit.properties > > logback.xml > > META-INF/ > > mini-kms-acls-default.xml
Yes, but I have checked, nothing depends on them. * log4j-kmsaudit.properties * logback.xml * META-INF/ Some code use files above, but they just read it from 'ranger-kms.jar', and the files reside in webapp/ is meaningless. Remember, no ClassLoader load classes under ews/webapp, so noone can call getResource to get them. * mini-kms-acls-default.xml Even no code read the file, it seems just a document to explain the hard-coded rules. - Kirby ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73816/#review223993 ----------------------------------------------------------- On 一月 24, 2022, 2:49 a.m., Kirby Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73816/ > ----------------------------------------------------------- > > (Updated 一月 24, 2022, 2:49 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-3595 > https://issues.apache.org/jira/browse/RANGER-3595 > > > Repository: ranger > > > Description > ------- > > https://issues.apache.org/jira/browse/RANGER-3595 > > > There are lots of .class files under ews/webapp/, and never used. > Becasue > 1. place web.xml at correct location > 2. setup.sh want to patch hadoop-common.jar at runtime, it requires some file > inside ranger-kms.jar. But the patching of hadoop-common.jar is unnecessary. > > My patch here makes maven no longer unpack ranger-kms.jar, and place web.xml > at correct location. > > > Diffs > ----- > > distro/src/main/assembly/kms.xml 32bbefa44e372f3abb41d60cd35aa0d706ca3100 > kms/scripts/setup.sh 2051df59a8bb0be11ba7a54e547f78cf5a0dca36 > kms/src/main/resources/WEB-INF/web.xml > 5e2d489fe632a16a5ed440bbbff41f558d2a2338 > > > Diff: https://reviews.apache.org/r/73816/diff/1/ > > > Testing > ------- > > mvn clean build package. > > fresh installion and upgrade. > > > Thanks, > > Kirby Zhou > >
