----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73839/#review224042 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java Line 512 (original), 511 (patched) <https://reviews.apache.org/r/73839/#comment313024> Consider changing this line to if (matchType != RangerPolicyResourceMatcher.MatchType.DESCENDANT) { as matchType should never be RangerPolicyResourceMatcher.MatchType.NONE when evaluatePolicyItems() is called. - Abhay Kulkarni On Feb. 11, 2022, 5:50 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73839/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2022, 5:50 p.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3617 > https://issues.apache.org/jira/browse/RANGER-3617 > > > Repository: ranger > > > Description > ------- > > fixed incorrect deny for _any access due to tag policy > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 0056f76d1 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 9ba418a43 > > agents-common/src/test/resources/policyengine/test_policyengine_descendant_tags.json > 1b3fc04ab > > agents-common/src/test/resources/policyengine/test_policyengine_descendant_tags_deny.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json > 7beb5abaa > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_for_show_databases.json > 1686b1ffe > > > Diff: https://reviews.apache.org/r/73839/diff/4/ > > > Testing > ------- > > - added unit tests to explcitly cover _any use case > - updated few incorrect existing tests > > > Thanks, > > Madhan Neethiraj > >
