----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73840/#review224044 -----------------------------------------------------------
Fix it, then Ship it! Changes look good. Thanks Abhishek! dev-support/ranger-docker/scripts/create-ranger-services.py Lines 8 (patched) <https://reviews.apache.org/r/73840/#comment313025> rename check(service) to service_not_exists(service) - Madhan Neethiraj On Feb. 12, 2022, 9:51 p.m., Abhishek Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73840/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2022, 9:51 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3610 > https://issues.apache.org/jira/browse/RANGER-3610 > > > Repository: ranger > > > Description > ------- > > Services are created for ranger plugins once ranger starts, they need to be > skipped when ranger container restarts. > > > Diffs > ----- > > dev-support/ranger-docker/Dockerfile.ranger ad895dce4 > dev-support/ranger-docker/scripts/create-ranger-services.py PRE-CREATION > dev-support/ranger-docker/scripts/ranger-hbase-service-dev_hbase.py > 80a3d4492 > dev-support/ranger-docker/scripts/ranger-hdfs-service-dev_hdfs.py f1b138e19 > dev-support/ranger-docker/scripts/ranger-hive-service-dev_hive.py c2bd7d720 > dev-support/ranger-docker/scripts/ranger-kafka-service-dev_kafka.py > 9f6cd79d1 > dev-support/ranger-docker/scripts/ranger-knox-service-dev_knox.py dceea53cb > dev-support/ranger-docker/scripts/ranger-yarn-service-dev_yarn.py 8f1ba712b > dev-support/ranger-docker/scripts/ranger.sh e2c0ddbf5 > > > Diff: https://reviews.apache.org/r/73840/diff/2/ > > > Testing > ------- > > Tested using containers for successful service creation. > Service creation is skipped if the services are already present. > > > Thanks, > > Abhishek Kumar > >
