----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73849/#review224051 -----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java Line 1192 (original), 1192 (patched) <https://reviews.apache.org/r/73849/#comment313027> we can remove this condition as we are using slf4j logging. Based on the log level configuration, slf4j Itself evaluate logger statement. We just have update the debug statement format to placehold format - bhavik patel On Feb. 15, 2022, 1:19 p.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73849/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2022, 1:19 p.m.) > > > Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary. > > > Bugs: RANGER-3625 > https://issues.apache.org/jira/browse/RANGER-3625 > > > Repository: ranger > > > Description > ------- > > The condition "if (!LOG.isDebugEnabled())" should be replaced by "if > (LOG.isDebugEnabled())" > so that the debug.level log inside this condition is logged. > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > e6cb50796 > > > Diff: https://reviews.apache.org/r/73849/diff/1/ > > > Testing > ------- > > Tested Manually and checked the debug log getting logged if the Debug is > enable. > > > Thanks, > > Ankita Sinha > >
