----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73856/#review224078 -----------------------------------------------------------
security-admin/src/main/webapp/WEB-INF/logback.xml Lines 32 (patched) <https://reviews.apache.org/r/73856/#comment313038> Is it necessary to remove log files from previous run on Ranger admin start (cleanHistoryOnStart=true)? Other than in dev environments, it will be desirable to persist logs across application restarts. security-admin/src/main/webapp/WEB-INF/logback.xml Line 78 (original), 88 (patched) <https://reviews.apache.org/r/73856/#comment313039> For perf appender, the level should be debug. Please retain existing value. - Madhan Neethiraj On Feb. 18, 2022, 1:22 p.m., Kirby Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73856/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2022, 1:22 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-3631 > https://issues.apache.org/jira/browse/RANGER-3631 > > > Repository: ranger > > > Description > ------- > > 1. The problematic pattern causes no line break in sql.log . > > > - <pattern>%d [%t] %-5p %C{6} (%F:%L) %msg%n</pattern> > + <pattern>%d [%t] %-5p %C{6} (%F:%L) %msg%n</pattern> > > > 2. "fatal" is a invalid log level in logback > > 3. maxHistory is missing in all. > 4. additivity is missing in "org.apache.ranger.perf" > > > Diffs > ----- > > security-admin/src/main/webapp/WEB-INF/logback.xml > 4b3e7b5717f2ed726fa50018e759dcddab26e19b > > > Diff: https://reviews.apache.org/r/73856/diff/1/ > > > Testing > ------- > > mvn clean build package. > > fresh installation and upgrade > > > Thanks, > > Kirby Zhou > >
