----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73838/#review224083 -----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java Lines 73 (patched) <https://reviews.apache.org/r/73838/#comment313045> this condition is not requird as we are using slf4j logger and update the logger statement to placeholder format. slf4j internally evaluate the logger statement based on the logger level. - bhavik patel On Feb. 21, 2022, 5:42 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73838/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2022, 5:42 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep > Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3613 > https://issues.apache.org/jira/browse/RANGER-3613 > > > Repository: ranger > > > Description > ------- > > - Added changes to check if master key with the given alias exists or not if > LUNA HSM is enabled. > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerHSM.java 4e960986d > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > 18a6bee57 > > > Diff: https://reviews.apache.org/r/73838/diff/2/ > > > Testing > ------- > > - Verified on local VM. > > > Thanks, > > Mateen Mansoori > >
