----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73863/ -----------------------------------------------------------
(Updated Feb. 24, 2022, 2:31 p.m.) Review request for ranger, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, and Ramesh Mani. Changes ------- Placed comments before checking the authorizer class name Bugs: RANGER-3638 https://issues.apache.org/jira/browse/RANGER-3638 Repository: ranger Description ------- RangerSolrAuthorizer is a common implementation call for both SearchComponent (for Document level Authorization) and AuthorizationPlugin (for collection level Authorization). RangerSolrAuthorizer implementation close() shutdowns the plugin and should be avoided when the call is for SearchComponent. Added check to get the authorizer class name to determine if the call is for SearchComponent of for the authorization plugin. Diffs (updated) ----- ranger-solr-plugin-shim/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java dfa219670 Diff: https://reviews.apache.org/r/73863/diff/2/ Changes: https://reviews.apache.org/r/73863/diff/1-2/ Testing ------- 1. Patched cluster with the changes and verified the end to end functionality with and without Document level authorization 2. Verified basic functional tests and audits for regression testing. Thanks, Sailaja Polavarapu