----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73882/#review224114 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java Line 156 (original), 156 (patched) <https://reviews.apache.org/r/73882/#comment313062> This changes the semantics of the REST API. Why is this change required? Please review. - Abhay Kulkarni On March 2, 2022, 1:09 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73882/ > ----------------------------------------------------------- > > (Updated March 2, 2022, 1:09 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3600 > https://issues.apache.org/jira/browse/RANGER-3600 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Ranger service tag import request may fail if > RangerServiceResource objects of ServiceTags objects does not have ranger > service name attribute values. > > **Proposed Solution** > 1) Use service name avaiable in the parent object(Servicetag object) > 2) Do not prune service name field while populating the RangerServiceResource > objects of the ServiceTag object. > 3) If guid is missing or service resource is not found based on guid then try > to find based on resource signature value. if not exist then do the create > operation. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerServiceTagsDeltaUtil.java > 76d5fd989 > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > 3897f48e2 > > > Diff: https://reviews.apache.org/r/73882/diff/1/ > > > Testing > ------- > > Tested the patch and able to import ServiceTags even if ServiceTags json does > not have service names in RangerServiceResource objects. > > > Thanks, > > Pradeep Agrawal > >
