----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73900/#review224164 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On March 15, 2022, 12:55 p.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73900/ > ----------------------------------------------------------- > > (Updated March 15, 2022, 12:55 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Mateen Mansoori, Mehul Parikh, Nitin Galave, Pradeep > Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3665 > https://issues.apache.org/jira/browse/RANGER-3665 > > > Repository: ranger > > > Description > ------- > > In the Ranger web console, when no conditions or exclusions of a certain type > are present, a message appears saying "No Data Found !!" > > > The wording, capitalization, and punctuation of this message all suggest > something is wrong. However, this condition is normal. For example, default > policies generally don't include any Deny conditions. Having no Deny > conditions isn't a problem, but the message in the UI gives a different > impression. > > I suggest replacing the current message that suggests an error with something > more low-key. Perhaps it could just say "(None)". > > Or maybe no message at all is needed. Unless an actual error is present, a > blank table is probably sufficient to convey that no items of that type are > present. > > > Diffs > ----- > > security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html > f41557748 > > > Diff: https://reviews.apache.org/r/73900/diff/1/ > > > Testing > ------- > > Changed the massage to 'No policy Item of "Allow Condition" are present' > Same for other policy item > > > Thanks, > > Dhaval Rajpara > >
