mneethiraj commented on a change in pull request #136:
URL: https://github.com/apache/ranger/pull/136#discussion_r830441433
##########
File path:
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
##########
@@ -1084,7 +1084,7 @@ private RangerAdminClient getAdminClient() throws
Exception {
try {
@SuppressWarnings("unchecked")
Class<RangerChainedPlugin> pluginClass =
(Class<RangerChainedPlugin>) Class.forName(className);
- RangerChainedPlugin chainedPlugin =
pluginClass.getConstructor(RangerBasePlugin.class,
String.class).newInstance(this, chainedService);
+ RangerChainedPlugin chainedPlugin =
pluginClass.getConstructor(RangerBasePlugin.class, String.class,
String.class).newInstance(this, pluginConfig.getServiceType(), chainedService);
Review comment:
@CanGuan - the expectation is that the class that implements
RangerChainedPlugin has a constructor that takes 2 arguments (RangerBasePlugin
parent, String serviceName), and that constructor calls RangerBasePlugin
constructor with 3 arguments (RangerBasePlugin parent, String serviceType,
String serviceName).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
