----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73903/#review224189 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On March 21, 2022, 11:58 a.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73903/ > ----------------------------------------------------------- > > (Updated March 21, 2022, 11:58 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Mateen Mansoori, Mehul Parikh, Nitin Galave, Pradeep > Agrawal, Vishal Suvagia, and Velmurugan Periasamy. > > > Bugs: RANGER-3667 > https://issues.apache.org/jira/browse/RANGER-3667 > > > Repository: ranger > > > Description > ------- > > 1. In Ranger's policy creation UI, when a resource (e.g. Hive database or > table name) is entered in the Policy Details, the autocomplete feature will > proactively present a dropdown of possible matches to known resource names > pulled from the service, which the user can then select to populate the > fields in the policy. > > > 2. If there is only one match to an existing resource name, then only that > single name will be presented in the dropdown. > > > 3. If there are no matches, then the text already entered into the field will > be presented in the autocomplete dropdown. This behavior is exactly the same > as (2) whether the resource exists or not. > > > 4. While there are some use cases where a policy may need to be created prior > to creating the actual resource itself, there is no validation or feedback in > the UI to indicate if a resource name already exists. In the case of a simple > typo error, this lack of feedback can result in the creation of invalid > policies that are then difficult to isolate and fix. > > > This request is to include some additional feedback ("not found" message or > similar) in the UI, to indicate when a resource does not exist. This would > also assist in identifying communication issues between Ranger and the > backend services. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/utils/XAUtils.js fa4916547 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 5b3940a10 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js > 68092fd62 > > security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js > 2cfdfd937 > security-admin/src/main/webapp/styles/xa.css ef3347be3 > > > Diff: https://reviews.apache.org/r/73903/diff/2/ > > > Testing > ------- > > checked resources in policy creation, zone creation, service creation page > and > All case "create" tag display while creating new option in select2 except > 1) Resource path field not display Create tag. > 2) Policy resource with "validationRegEx" not display Create tag > > > Thanks, > > Dhaval Rajpara > >
