[ 
https://issues.apache.org/jira/browse/RANGER-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517275#comment-17517275
 ] 

Pradeep Agrawal commented on RANGER-3632:
-----------------------------------------

This commit is causing test/build failure, hence reopening this : 
[https://github.com/apache/ranger/commit/db99f639017bc9bbd71a7c5772adc1545ca83ec0]
{code:java}
Tests run: 57, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.296 sec - in 
org.apache.ranger.rest.TestServiceREST
12:53:57.125 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - ==> 
JVMShutdownHook.run()
12:53:57.125 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Signalling async audit cleanup to start.
12:53:57.125 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Starting cleanup
12:53:57.125 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Waiting up to 30 seconds for audit cleanup to finish.
12:53:57.125 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.queue.AuditAsyncQueue - Stop called. name=test.async
12:53:57.125 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Done cleanup
12:53:57.125 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Waiting to audit cleanup start signal
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: Audit 
cleanup finished after 1 milli seconds
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Interrupting ranger async audit cleanup thread
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - <== 
JVMShutdownHook.run()
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - ==> 
JVMShutdownHook.run()
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Signalling async audit cleanup to start.
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Waiting up to 30 seconds for audit cleanup to finish.
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Interrupted while waiting for audit startCleanup 
signal!  Exiting the thread...
java.lang.InterruptedException: null
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:998)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
        at java.util.concurrent.Semaphore.acquire(Semaphore.java:312)
        at 
org.apache.ranger.audit.provider.AuditProviderFactory$RangerAsyncAuditCleanup.run(AuditProviderFactory.java:501)
        at java.lang.Thread.run(Thread.java:748)
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Starting cleanup
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.queue.AuditAsyncQueue - Stop called. name=test.async
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Done cleanup
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Waiting to audit cleanup start signal
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: Audit 
cleanup finished after 0 milli seconds
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - JVMShutdownHook: 
Interrupting ranger async audit cleanup thread
12:53:57.126 [shutdown-hook-0] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - <== 
JVMShutdownHook.run()
12:53:57.126 [Ranger async Audit cleanup] INFO 
org.apache.ranger.audit.provider.AuditProviderFactory - 
RangerAsyncAuditCleanup: Interrupted while waiting for audit startCleanup 
signal!  Exiting the thread...
java.lang.InterruptedException: null
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:998)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
        at java.util.concurrent.Semaphore.acquire(Semaphore.java:312)
        at 
org.apache.ranger.audit.provider.AuditProviderFactory$RangerAsyncAuditCleanup.run(AuditProviderFactory.java:501)
        at java.lang.Thread.run(Thread.java:748)
12:53:57.126 [Thread-2] DEBUG org.apache.hadoop.util.ShutdownHookManager - 
Completed shutdown in 0.002 seconds; Timeouts: 0
12:53:57.131 [Thread-2] DEBUG org.apache.hadoop.util.ShutdownHookManager - 
ShutdownHookManger completed shutdown.


Results :


Failed tests: 
  TestSecurityZoneREST.testUpdateSecurityZoneWithMisMatchId 
Expected: an instance of javax.ws.rs.WebApplicationException
     but: <java.lang.NullPointerException> is a java.lang.NullPointerException
Stacktrace was: java.lang.NullPointerException
        at 
org.apache.ranger.plugin.model.RangerSecurityZone$RangerSecurityZoneService.toString(RangerSecurityZone.java:157)
        at java.lang.String.valueOf(String.java:2994)
        at java.lang.StringBuilder.append(StringBuilder.java:131)
        at java.util.AbstractMap.toString(AbstractMap.java:559)
        at java.lang.String.valueOf(String.java:2994)
        at java.lang.StringBuilder.append(StringBuilder.java:131)
        at 
org.apache.ranger.plugin.model.RangerSecurityZone.toString(RangerSecurityZone.java:117)
        at java.lang.String.valueOf(String.java:2994)
        at java.lang.StringBuilder.append(StringBuilder.java:131)
        at 
org.apache.ranger.rest.SecurityZoneREST.updateSecurityZone(SecurityZoneREST.java:140)
        at 
org.apache.ranger.rest.TestSecurityZoneREST.testUpdateSecurityZoneWithMisMatchId(TestSecurityZoneREST.java:185)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:44)
        at 
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at 
org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:74)
        at 
org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:80)
        at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
        at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
        at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
        at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Tests in error: 
  
TestPolicyDb.testPolicyDb_hdfs:86->runTestsFromResourceFiles:101->runTests:123 
» NullPointer
  
TestPolicyDb.testPolicyDb_hive:93->runTestsFromResourceFiles:101->runTests:123 
» NullPointer
  TestUserMgr.test11CreateDefaultAccountUser:808 » NullPointer
  TestUserMgr.test12CreateDefaultAccountUser:846 » NullPointer
  TestSecurityZoneREST.testCreateSecurityZone:131 » NullPointer
  TestSecurityZoneREST.testGetSecurityZoneById:197 » NullPointer
  TestSecurityZoneREST.testGetSecurityZoneByName:209 » NullPointer
  TestSecurityZoneREST.testUpdateSecurityZone:156 » NullPointer


Tests run: 827, Failures: 1, Errors: 8, Skipped: 3 {code}

> Improve ranger logs,  RENAME_ON_ROTATE and others
> -------------------------------------------------
>
>                 Key: RANGER-3632
>                 URL: https://issues.apache.org/jira/browse/RANGER-3632
>             Project: Ranger
>          Issue Type: Improvement
>          Components: admin, kms
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: kirby zhou
>            Assignee: kirby zhou
>            Priority: Major
>             Fix For: 3.0.0, 2.3.0
>
>
> Currently, the filename of the access-log in use has a timestamp as the 
> suffix. This brings trouble to some log monitoring and analysis programs, 
> such as "tail -f access-log"
> Need to add an option to enable tomcat's RenameOnRotate capability to fix the 
> file name of access-log.
>  
> {code:java}
> // in EmbeddedServer::start()
> valve.setRenameOnRotate(
> EmbeddedServerUtil.getConfig(ACCESS_LOG_RENAME_ON_ROTATE,  false);
> );{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to