> On 三月 30, 2022, 7:44 a.m., Kishor Gollapalliwar wrote: > > Ship It!
Anybody can commit it? - Kirby ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73835/#review224229 ----------------------------------------------------------- On 三月 3, 2022, 3:48 a.m., Kirby Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73835/ > ----------------------------------------------------------- > > (Updated 三月 3, 2022, 3:48 a.m.) > > > Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, > Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen > Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal > Suvagia, and Velmurugan Periasamy. > > > Bugs: RANGER-3611 > https://issues.apache.org/jira/browse/RANGER-3611 > > > Repository: ranger > > > Description > ------- > > A simple Rest API call by CURL will cause uncatched NullPointerException in > logs. > It happens at some spring generated code. Set a value to lastKnownVersion > will fix it > > Actual: > > ``` > ]% curl -v http://localhost:6080/service/plugins/policies/download/hdfsdev > ... > < HTTP/1.1 404 Not Found > ... > #### No Message here #### > * Closing connection 0 > ``` > > And logs in catalina.out > > ``` > EVERE: Servlet.service() for servlet [REST Service] in context with path [] > threw exception > java.lang.NullPointerException > at > org.apache.ranger.rest.ServiceREST.getServicePoliciesIfUpdated(ServiceREST.java:3054) > at > org.apache.ranger.rest.ServiceREST$$FastClassBySpringCGLIB$$92dab672.invoke(<generated>) > at > org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:779) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:750) > at > org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123) > at > org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388) > at > org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) > at > org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:750) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:692) > at > org.apache.ranger.rest.ServiceREST$$EnhancerBySpringCGLIB$$43bccb60.getServicePoliciesIfUpdated(<generated>) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) > at > com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) > at > com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) > at > com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) > at > com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542) > at > com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419) > at > com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409) > at > com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558) > at > com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:232) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) > at > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:194) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) > at > org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:204) > at > org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:183) > at > org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:358) > at > org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:271) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:194) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202) > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) > at > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:544) > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:143) > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) > at > org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698) > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:364) > at > org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:624) > at > org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) > at > org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:831) > at > org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1651) > at > org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at > org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) > at java.lang.Thread.run(Thread.java:748) > ``` > > > Expected: > > ``` > ]% curl -v > http://localhost:6080/service/plugins/policies/download/hdfsdev?lastKnownVersion=-1 > > ... > < HTTP/1.1 404 Not Found > ... > "RANGER_ERROR_SERVICE_NOT_FOUND: ServiceName=hdfsdev" > * Closing connection 0 > ``` > > And no errors in catalina.out > > > Simple Fix: change from first to second fragment in method > org.apache.ranger.rest.ServiceREST::getServicePoliciesIfUpdated(...) > if (isValid) { > if (lastKnownVersion == null) { > lastKnownVersion = Long.valueOf(-1); > } > if (lastKnownVersion == null) { > lastKnownVersion = Long.valueOf(-1); > } > if (isValid) { > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java > 90f9690de7387d9842743b4827f936a236edb1c7 > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java > e3cdef1c2ba6411cf4d4a26cd49e56e9017f3e93 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 098188e3b9f1f837727c7d279a4fab1f0aa84e34 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java > 451805321d050dda06a0f2b66a9b945411632e2f > > > Diff: https://reviews.apache.org/r/73835/diff/3/ > > > Testing > ------- > > mvn clean build test. > fresh installation. > > > Thanks, > > Kirby Zhou > >
