-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73941/#review224296
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
Line 1103 (original), 1113 (patched)
<https://reviews.apache.org/r/73941/#comment313153>

    result.policyId could be -1 when isAccessDetermined=true, for example when 
user is a superuser. And Solr plugin has a differnt scenario which would have 
policyId=-1 and isAccessDetermined=true.
    
    With this update, such decisions would be overwritten by chained plugin. 
Please review.


- Madhan Neethiraj


On April 11, 2022, 5:58 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73941/
> -----------------------------------------------------------
> 
> (Updated April 11, 2022, 5:58 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-3705
>     https://issues.apache.org/jira/browse/RANGER-3705
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add/improve logging messages to help debugging potential issues.
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java
>  7b02dd6e1 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java
>  331d6371d 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  12fecd030 
> 
> 
> Diff: https://reviews.apache.org/r/73941/diff/1/
> 
> 
> Testing
> -------
> 
> Built clean and passed all unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

Reply via email to