----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73940/#review224303 -----------------------------------------------------------
Ship it! Ship It! - bhavik patel On April 11, 2022, 1:19 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73940/ > ----------------------------------------------------------- > > (Updated April 11, 2022, 1:19 p.m.) > > > Review request for ranger, bhavik patel, Abhay Kulkarni, Madhan Neethiraj, > Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** While checking c3p0 debug logs for oracle db flavor > found that 'preferredTestQuery' config of c3p0 does not understand sql > termination character ; and throws logs. I also suspect that it affectes > application performance and connection pool management. > > **Proposed statement:** removal of ; from the test connection sql stops the > exception logs. > > > Diffs > ----- > > security-admin/scripts/setup.sh 7dc11d8f8 > security-admin/src/main/resources/conf.dist/logback.xml 997f3bc59 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > e2bfc8fff > > > Diff: https://reviews.apache.org/r/73940/diff/1/ > > > Testing > ------- > > Tested the patch and verfied the c3p0 debug logs with mysql,postgres and > oracle db flavor. > > > Thanks, > > Pradeep Agrawal > >
