-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73984/#review224438
-----------------------------------------------------------




distro/pom.xml
Lines 586 (patched)
<https://reviews.apache.org/r/73984/#comment313239>

    Remove activation from individual profile
    
    Please remove this jdk11 activation because it is covered in the 
ranger-jdk11 profile. I have tested that if we keep this then only trino tar is 
getting created. 
    
    I have tested that even if we remove this it is not causing any problem in 
JDK8 because trino plugin is removed from default profile so it will be 
triggered only if jdk11 is used.



pom.xml
Lines 625-627 (patched)
<https://reviews.apache.org/r/73984/#comment313240>

    Remove activation from individual profile
    
    Please remove this jdk11 activation because it is covered in the 
ranger-jdk11 profile. I have tested that if we keep this then only trino tar is 
getting created. 
    
    I have tested that even if we remove this it is not causing any problem in 
JDK8 because trino plugin is removed from default profile so it will be 
triggered only if jdk11 is used.


- Aakash Nand


On May 11, 2022, 8:25 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73984/
> -----------------------------------------------------------
> 
> (Updated May 11, 2022, 8:25 p.m.)
> 
> 
> Review request for ranger, Aakash Nand and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-3755
>     https://issues.apache.org/jira/browse/RANGER-3755
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3755:Build Plugin-Trino artifacts only with JDK 11
> 
> 
> Diffs
> -----
> 
>   distro/pom.xml 45a2164a6 
>   pom.xml cc62a6fa4 
> 
> 
> Diff: https://reviews.apache.org/r/73984/diff/2/
> 
> 
> Testing
> -------
> 
> - Verified in local build.
> - Apache Ranger builds without issue with Plugin Trino Patch in place.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to