----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73986/#review224444 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On May 16, 2022, 3:17 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73986/ > ----------------------------------------------------------- > > (Updated May 16, 2022, 3:17 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3764 > https://issues.apache.org/jira/browse/RANGER-3764 > > > Repository: ranger > > > Description > ------- > > - added support for following macros in condition expressions: > -- IS_IN_GROUP(groupName) > -- IS_IN_ROLE(roleName) > -- HAS_TAG(tagName) > -- HAS_USER_ATTR(attrName) > -- HAS_UG_ATTR(attrName) > -- HAS_TAG_ATTR(attrName) > - these macros make it easier to write conditions like: > -- test if user is part of multiple groups: IS_IN_GROUP('group1') && > IS_IN_GROUP('group2') > -- test if resource has multiple tags: HAS_TAG('tag1') && HAS_TAG('tag2') > -- test if any of groups the user belongs has attribute attr1: > HAS_UG_ATTR('attr1') > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > dbc055b19 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java > c98cce0e6 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java > 7bbad7842 > > > Diff: https://reviews.apache.org/r/73986/diff/1/ > > > Testing > ------- > > - added unit tests to cover new macros > - verified that existing unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
