----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73994/#review224454 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 18, 2022, 10:28 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73994/ > ----------------------------------------------------------- > > (Updated May 18, 2022, 10:28 p.m.) > > > Review request for ranger, Harshal Chavan, Madhan Neethiraj, Mehul Parikh, > and Ramesh Mani. > > > Bugs: RANGER-3769 > https://issues.apache.org/jira/browse/RANGER-3769 > > > Repository: ranger > > > Description > ------- > > A service contains no policies but is associated with a tag-service with some > tag policies. If the tag-service is disassociated from the service, then the > policy-engine does not get updated and continues to enforce tag policies in > the formerly associated tag-service. > > Fix : RangerPolicyUtilDelta.hasPolicyDeltas() now differentiates between two > cases when service-policies do not contain either policies or policy-deltas. > If service-policies object was created with all policies or with deltas. If > former, then new policy-engine needs to be created, otherwise, no material > changes to policies are present and old policy-engine can continue to be used. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java > 43a494093 > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java > 1ca4415ae > > > Diff: https://reviews.apache.org/r/73994/diff/1/ > > > Testing > ------- > > Passes all unit tests. > > > Thanks, > > Abhay Kulkarni > >
