----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74007/#review224479 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java Lines 64 (patched) <https://reviews.apache.org/r/74007/#comment313248> Consider using log level DEBUG here to avoid excessive logs. ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java Line 94 (original), 87 (patched) <https://reviews.apache.org/r/74007/#comment313250> It will help to retain populating pluginClassLoaders even when pluginType is null, so that subsequent calls with pluginType=null will return quickly from #61. if (ret != null) { pluginClassLoaders.put(pluginType, ret); if (pluginType != null && !pluginType.equals(TAG_SERVICE_TYPE)) { pluginClassLoaders.put(TAG_SERVICE_TYPE, ret); } } ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java Lines 364 (patched) <https://reviews.apache.org/r/74007/#comment313249> Consider using log level DEBUG in #364 and #367 to avoid excessive logs. - Madhan Neethiraj On June 2, 2022, 3:02 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74007/ > ----------------------------------------------------------- > > (Updated June 2, 2022, 3:02 p.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-3606 > https://issues.apache.org/jira/browse/RANGER-3606 > > > Repository: ranger > > > Description > ------- > > JDK 11 JRE fails to create javascript Script-Engine for tag policies > containing script conditions > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/ScriptEngineUtil.java > 79a702a8f > > ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java > 7ed776ecb > > > Diff: https://reviews.apache.org/r/74007/diff/2/ > > > Testing > ------- > > Tested with JDK11. Passes all unit tests. > > > Thanks, > > Abhay Kulkarni > >
