----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74031/#review224520 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 491 (patched) <https://reviews.apache.org/r/74031/#comment313267> Iterator is actually not required, you can use for loop to iterate the map security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 505 (patched) <https://reviews.apache.org/r/74031/#comment313268> what if accessStr.length() = 0 ? - bhavik patel On June 20, 2022, 6:44 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74031/ > ----------------------------------------------------------- > > (Updated June 20, 2022, 6:44 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, > Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3797 > https://issues.apache.org/jira/browse/RANGER-3797 > > > Repository: ranger > > > Description > ------- > > If solr service config contains no longer supported access types e.g - > others, solr_admin then service/zone service creation will fail. > > Added changes in java patch to handle upgrade case (Before upgrade If serivce > config had others or solr_admin access types then removing and updating the > service config during upgrade.) > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java > 949967cd3 > > > Diff: https://reviews.apache.org/r/74031/diff/1/ > > > Testing > ------- > > Verified upgrade and checked able to create security zone. > > > Thanks, > > Mateen Mansoori > >
