----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74038/#review224535 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On June 27, 2022, 4:31 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74038/ > ----------------------------------------------------------- > > (Updated June 27, 2022, 4:31 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Kishor > Gollapalliwar, Abhay Kulkarni, Nitin Galave, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3796 > https://issues.apache.org/jira/browse/RANGER-3796 > > > Repository: ranger > > > Description > ------- > > 1. added RangerPolicy.additionalResources to enable adding resource-sets to a > policy > 2. Renamed interface RangerPolicyResourceEvaluator to > RangerResourceEvaluator, as this was implemented for service-resource and > zone-resource as well > 3. RangerPolicyEvalauator updated to not implement RangerResourceEvaluator, > instead a policy evaluator will contain a number of RangerResourceEvaluator > instances > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java > 9433ae1da > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > ea4099966 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java > 02d0a863f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 0a58bb36d > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > 62970ad9f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java > c6cc9ac72 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 5b3c9c3e5 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 07cbe7ff6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > 70b9f6884 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > ad102a765 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java > ace4e30ac > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultDataMaskPolicyItemEvaluator.java > f7e5f81f8 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 0f2c55456 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 0b7f7ba12 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 3060214ec > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java > 9da9fac66 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceMatcher.java > 7978e7fdf > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java > 0c6c4c206 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPathResourceTrie.java > 90e4575e3 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 824516add > > agents-common/src/test/resources/policyengine/test_policyengine_policy_with_additional_resources.json > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdmin.java > f1ce602cb > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java > df75db11a > security-admin/src/test/java/org/apache/ranger/biz/TestPolicyAdmin.java > PRE-CREATION > security-admin/src/test/java/org/apache/ranger/biz/TestPolicyDb.java > 7416fe45d > > security-admin/src/test/resources/biz/test_policyadmin_additional_resources.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74038/diff/2/ > > > Testing > ------- > > 1. added unit tests to cover multiple resource-sets in a policy > 2. verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
