----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74056/#review224560 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On July 13, 2022, 4:29 p.m., Andras Katona wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74056/ > ----------------------------------------------------------- > > (Updated July 13, 2022, 4:29 p.m.) > > > Review request for ranger, Ramesh Mani and Viktor Somogyi-Vass. > > > Bugs: RANGER-3809 > https://issues.apache.org/jira/browse/RANGER-3809 > > > Repository: ranger > > > Description > ------- > > Since the current implementation of the acls() call throws > UnsupportedOperationException, it masks an authorization error if a > Kafka client tries to call the InitProducerId API and doesn't have > idempotent_write permission on the cluster nor it has a transactional.id > configured. > > Until a proper implementation of the acls() method is done by RANGER-3809 > we override authorizeByResourceType to get an access denied on the > client side instead of an exception. > > > Diffs > ----- > > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > 64f622586 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > e82de1849 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java > b25d1fdd1 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > d24ee1e57 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java > 201064970 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaTestUtils.java > dc8277051 > plugin-kafka/src/test/resources/kafka-policies.json 70c978cce > > > Diff: https://reviews.apache.org/r/74056/diff/1/ > > > Testing > ------- > > unit tests, manually > > > Thanks, > > Andras Katona > >
