-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74062/
-----------------------------------------------------------
Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan
Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan
Periasamy.
Bugs: Ranger-3834
https://issues.apache.org/jira/browse/Ranger-3834
Repository: ranger
Description
-------
Unit test cases for RoleREST.java were missing.
In RoleDBStore.java, RangerDaoManager was being accesed like
"roleRefUpdater.daoMgr" directly instead of using getter.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java f501f2896
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java
012d4c02f
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
PRE-CREATION
Diff: https://reviews.apache.org/r/74062/diff/1/
Testing
-------
1) Wrote unit test cases for RoleREST.java in a file TestRoleREST.java
2) Added getter for RangerDaoManager in RoleRefUpdater instead of accessing the
member variable directly -- to make code more testable.
2) Ran all the written test cases -- all test cases passed (Method coverage::
97.1% (33/34) Line coverage:: 74.4% (490/659))
Thanks,
Fateh Singh
