----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74094/#review224639 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Aug. 23, 2022, 8:31 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74094/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2022, 8:31 p.m.) > > > Review request for ranger, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan > Periasamy. > > > Bugs: RANGER-3864 > https://issues.apache.org/jira/browse/RANGER-3864 > > > Repository: ranger > > > Description > ------- > > Atlas emits notifications when entities change or classifications are > added/changed/deleted from them. If the change to entity does not involve > changes/additions/deletions to its classifications, then Ranger need not > create service-resource object corresponding to the Atlas entity in the > Ranger database. Similarly, if a classification is removed from an entity > then Ranger need to keep such untagged entity in its database. > > The patch consists of : > tagsync (client) side changes: to ensure that only those Atlas notifications > which need to be handled are converted into the data structure accepted by > Ranger REST endpoint and uploaded to Ranger. > ranger-admin )server) side changes: If no classifications are associated with > the service_instance object, in the uploaded data then corresponding > service_instance object is also removed. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > b256e2838 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > 1b81bafae > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 2f93ebd31 > > > Diff: https://reviews.apache.org/r/74094/diff/1/ > > > Testing > ------- > > Tested with real cluster to ensure that there only entries for tagged > entities in x_service_instance database table in Ranger. > > > Thanks, > > Abhay Kulkarni > >
