----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74122/#review224674 -----------------------------------------------------------
Fix it, then Ship it! security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql Line 120 (original), 120 (patched) <https://reviews.apache.org/r/74122/#comment313469> Pradeep - while at this, I suggest similar change for other columns as well: notes, other_attributes. - Madhan Neethiraj On Sept. 15, 2022, 5:08 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74122/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2022, 5:08 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3914 > https://issues.apache.org/jira/browse/RANGER-3914 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** > Ranger install or upgrade may fail with below error when mysql engine having > database charset set to utfmb4. > > com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: > Row size too large. The maximum row size for the used table type, not > counting BLOBs, is 65535. > This includes storage overhead, check the manual. You have to change some > columns to TEXT or BLOBs > > SQLException : SQL state: 42000 > com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Row size too > large. The maximum row size for the used table type, not counting BLOBs, is > 65535. This includes storage overhead, check the manual. You have to change > some columns to TEXT or BLOBs ErrorCode: 1118 > > **Proposed solution:** > Since BLOBs are not counted in the calculation of row size we can change > sync_source column type to Blob/text/clob type. > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 309c4196b > > security-admin/db/mysql/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql > 5a40a89e0 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 1af0a04ac > > security-admin/db/oracle/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql > ed8dbaf7f > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > baa6288d2 > > security-admin/db/postgres/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql > 68117a123 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 5e8070ba2 > > security-admin/db/sqlanywhere/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql > 335459058 > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > 8b5833eae > > security-admin/db/sqlserver/patches/055-add-syncSource-col-in-x_user-x_portal_user-x_group.sql > 3b8a8d83a > > > Diff: https://reviews.apache.org/r/74122/diff/1/ > > > Testing > ------- > > Tested Ranger install and upgrade with this patch which was failing earlier. > > > Thanks, > > Pradeep Agrawal > >
