----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74148/#review224757 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java Line 168 (original), 172 (patched) <https://reviews.apache.org/r/74148/#comment313533> With the new findByRoleId() methods returning List<Long>, how about directly assigning to xxRoleRefUserIds, xxRoleRefRoleIds and xxRoleRefGroupByIds - like: List<Long> xxRoleRefUserIds = xRoleUserDao.findIdsByRoleId(roleId); List<Long> xxRoleRefRoleIds = xRoleRoleDao.findIdsByRoleId(roleId); List<Long> xxRoleRefGroupByIds = xRoleGroupDao.findIdsByRoleId(roleId); - Madhan Neethiraj On Oct. 6, 2022, 6:09 p.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74148/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2022, 6:09 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3900 > https://issues.apache.org/jira/browse/RANGER-3900 > > > Repository: ranger > > > Description > ------- > > We used DB batch write call instead of 1 DB write call for every > user,role,group deference > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RoleRefUpdater.java > 56f7ec4c8 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > fc56ff88b > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java > a8233e30c > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefConditionDao.java > bc17fcdb0 > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefDataMaskTypeDao.java > df5f7cd94 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefGroupDao.java > dc41aeadb > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefResourceDao.java > 738c6ff49 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java > 35433c758 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefUserDao.java > eced7b261 > security-admin/src/main/java/org/apache/ranger/db/XXRoleRefGroupDao.java > eb470f260 > security-admin/src/main/java/org/apache/ranger/db/XXRoleRefRoleDao.java > 8f6fc8cfa > security-admin/src/main/java/org/apache/ranger/db/XXRoleRefUserDao.java > ba9fb494b > security-admin/src/main/resources/META-INF/jpa_named_queries.xml e4a2354b0 > > > Diff: https://reviews.apache.org/r/74148/diff/3/ > > > Testing > ------- > > test with 1 Role contains 1k other roles and 1k groups > while deleting the role it took 11.577 seconds > After fix > it took 1.021 seconds > > > Thanks, > > Ramachandran Krishnan > >
