----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74171/#review224799 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Oct. 14, 2022, 5:10 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74171/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2022, 5:10 p.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, > Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3948 > https://issues.apache.org/jira/browse/RANGER-3948 > > > Repository: ranger > > > Description > ------- > > replaced Json serailzation annotation NON_NULL with NON_EMPTY > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java > d55667c57 > > agents-common/src/main/java/org/apache/ranger/admin/client/datatype/RESTResponse.java > d5ec66bac > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagForEval.java > 1c634b393 > agents-common/src/main/java/org/apache/ranger/plugin/model/AuditFilter.java > b437e14d9 > agents-common/src/main/java/org/apache/ranger/plugin/model/GroupInfo.java > 5925014da > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerBaseModelObject.java > 0273f7e8f > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java > 2ee756f00 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java > 5b9256620 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 095fc9abf > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyDelta.java > 5292a98cb > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerRole.java > 54b73f9f2 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java > 49887770b > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneHeaderInfo.java > e9d6b1be3 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java > 44600b839 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > db13b7baf > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java > 4343f6f1a > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java > 47d006048 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceTags.java > 8f59aa5ee > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java > 9e620c32c > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java > f1a83cfaf > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagResourceMap.java > a41bf1899 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValidityRecurrence.java > 23b4a8c6f > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerValiditySchedule.java > d2271aec5 > > agents-common/src/main/java/org/apache/ranger/plugin/model/ServiceDeleteResponse.java > cd9f784c6 > agents-common/src/main/java/org/apache/ranger/plugin/model/UserInfo.java > 3e933e8fa > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java > e0c0f94a9 > > agents-common/src/main/java/org/apache/ranger/plugin/service/ResourceLookupContext.java > 25b552183 > > agents-common/src/main/java/org/apache/ranger/plugin/store/StoredServiceResource.java > 644f2cee3 > > agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRequest.java > 63f0f2598 > > agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRoleRequest.java > 04b4e722e > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestedResources.java > a5107b367 > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRoles.java > 354bf4485 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStore.java > d0629152c > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java > 71b532a5e > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java > b4f250038 > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > c7d280b60 > > > Diff: https://reviews.apache.org/r/74171/diff/2/ > > > Testing > ------- > > - verified that all unit tests pass successfully > - observed that downloaded tags size reduced by ~20% - from 182mb to 146mb, > for ~254k resources & 762k tags > > > Thanks, > > Madhan Neethiraj > >
