-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74167/
-----------------------------------------------------------
(Updated Oct. 28, 2022, 3:52 p.m.)
Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor
Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja
Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Changes
-------
updates to address review comment.
Bugs: RANGER-3888
https://issues.apache.org/jira/browse/RANGER-3888
Repository: ranger
Description
-------
- updated unit tests to add more details in failure messages to make
troubleshooting easier
- updated tests for valid range for month: 0-11
- updated validation logic to fail only when a given range is completely
outside the valid range; earlier validation used to fail even if either min or
max fall out of range
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
1e38118f7
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
59c50e4ca
agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json
321df659f
Diff: https://reviews.apache.org/r/74167/diff/3/
Changes: https://reviews.apache.org/r/74167/diff/2-3/
Testing
-------
- verified that TestPolicyEngine tests pass successfully
Thanks,
Madhan Neethiraj
