----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72939/#review224844 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java Lines 187 (patched) <https://reviews.apache.org/r/72939/#comment313723> The new methods XGroupUserDao.findByLoginIdList() and XGroupUserDao.findByIdList() are not used. Please review and remove. security-admin/src/main/java/org/apache/ranger/service/XUserService.java Lines 365 (patched) <https://reviews.apache.org/r/72939/#comment313721> Consider avoiding ArrayList creation by updating findByLoginIdList() parameter type to from List<> to Collection<>. security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java Lines 132 (patched) <https://reviews.apache.org/r/72939/#comment313722> Given addedByUser and updatedByUser are likely to have duplicates, consider collecting them into a Set<>, instead of List<>. Also, consider updating findByIdList() to receive a Collection<>, instead of List<>. - Madhan Neethiraj On Oct. 29, 2022, 10:53 a.m., Bill Ricky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72939/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2022, 10:53 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-3027 > https://issues.apache.org/jira/browse/RANGER-3027 > > > Repository: ranger > > > Description > ------- > > RANGER-3027: Improve response time for GET API service/xusers/users > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java > 76cdd93f5 > security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java > 1787eeae6 > security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > d7c011ca3 > > security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java > 25fec3dd4 > security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213 > > > Diff: https://reviews.apache.org/r/72939/diff/5/ > > > Testing > ------- > > done > > > File Attachments > ---------------- > > 0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch > > https://reviews.apache.org/media/uploaded/files/2022/10/29/88fd4c1a-32cf-4c2a-9b64-0e64471d39bf__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch > > > Thanks, > > Bill Ricky > >
