----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74191/#review224909 -----------------------------------------------------------
Ramachandran - patch at https://reviews.apache.org/r/74221 addresses multiple KMS issues, including the one fixed in this patch. Please review. - Madhan Neethiraj On Nov. 28, 2022, 4:04 a.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74191/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2022, 4:04 a.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-2271 > https://issues.apache.org/jira/browse/RANGER-2271 > > > Repository: ranger > > > Description > ------- > > Inside RangerKeyStoreProvider#createKey(), the code write cache first > > cache.put(name, meta); > > Then write to keyStore > > innerSetKeyVersion(...) > > > > If innerSetKeyVersion() failed, the cache will have the key which doesn't > exist in keyStore. > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > cb5739f61 > > > Diff: https://reviews.apache.org/r/74191/diff/1/ > > > Testing > ------- > > > Thanks, > > Ramachandran Krishnan > >
