> On Dec. 2, 2022, 2:21 a.m., Madhan Neethiraj wrote: > > @Ramachandra - fix to address build issues in Apple M1/M2 environments was > > merged in RANGER-3863 (review: https://reviews.apache.org/r/74092/). Can > > you please try after getting the latest from master/ranger-2.4 branch?
Thanks Madhan .I am able to build in M1 Mac without issues .Let me close this PR - Ramachandran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74113/#review224932 ----------------------------------------------------------- On Nov. 28, 2022, 10:01 a.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74113/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2022, 10:01 a.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3908 > https://issues.apache.org/jira/browse/RANGER-3908 > > > Repository: ranger > > > Description > ------- > > While building latest (master branch) Ranger, I started getting following > build error : > > Failed to execute goal > com.github.eirslett:frontend-maven-plugin:1.6:install-node-and-npm (install > node and npm) on project security-admin-web: Could not download Node.js: Got > error code 404 from the server. > > Module Failed: Security Admin Web Application > > Command executed: mvn -DskipTests=true clean compile package install > assembly:assembly > > Self Analysis: Further I found security-admin module was trying to download > node plugin that actually doesn't exists. > > Following is the trace from build log. > > INFO] -- frontend-maven-plugin:1.6:install-node-and-npm (install node and > npm) @ security-admin-web -- > > [*INFO*] Installing node version v8.12.0 > > [*INFO*] Downloading > *https://nodejs.org/dist/v8.12.0/node-v8.12.0-darwin-arm64.tar.gz* to > /Users/vikaskr/.m2/repository/com/github/eirslett/node/8.12.0/node-8.12.0-darwin-arm64.tar.gz > > [*INFO*] No proxies configured > > [*INFO*] No proxy was configured, downloading directly > > > > Possible RCA: It could be due to my machine configuration which is "Apple M1 > (Chip) Pro". Maven is trying to download the ARM64 based artifact but NodeJS > v16.0.0 onwards has such artifacts (https://nodejs.org/dist/v16.0.0/) > > After updating the version in pom.xml, it worked. > > <nodeVersion>v16.9.1</nodeVersion>. // existing version is v8.12.0 > > <npmVersion>7.24.2</npmVersion>. // existing version is 6.4.1 > > > > Either nodeJS and npm versions should be updated or it should be made > configurable to pass the version through mvn command line. > > > Diffs > ----- > > security-admin/pom.xml 33ffc95e2 > > > Diff: https://reviews.apache.org/r/74113/diff/1/ > > > Testing > ------- > > Adding -DskipJSTests=true (as part of mvn command) , will ignore npm install > and it's js test cases running in security-admin module which will unblock > Mac M1 users > When we skip -DskipJSTests=true , we do not need to do > npm install or > npm run r.js that are not needed . > As well as this fix will unblock M1 Mac users to build ranger code locally > without any issues > > > Thanks, > > Ramachandran Krishnan > >
