> On Dec. 9, 2022, 5:56 a.m., Ramesh Mani wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > > Lines 574 (patched) > > <https://reviews.apache.org/r/74242/diff/2/?file=2272455#file2272455line574> > > > > should there be a null check for dataMaskPolicyEvaluators and other > > evaluvators?
policyEvaluators, datamaskPolicyEvaluators and rowFilterPolicyEvaluators are initialized to a non-null value in init() and auditPolicyEvaluators are set to non-null in buildAuditPolicyEvaluators(). - Abhay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74242/#review224988 ----------------------------------------------------------- On Dec. 9, 2022, 4:37 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74242/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2022, 4:37 a.m.) > > > Review request for ranger, madhan, Madhan Neethiraj, Pradeep Agrawal, Ramesh > Mani, and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > It is useful to make some internal policy engine APIs and metrics accessible > to public in a read-only mode to help make more efficient use of policy > engine resources. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 8d80ad6a3 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 85a3afd01 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > ba1467828 > > > Diff: https://reviews.apache.org/r/74242/diff/2/ > > > Testing > ------- > > Passed all unit tests > > > Thanks, > > Abhay Kulkarni > >
