----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74331/#review225238 -----------------------------------------------------------
LGTM. +1 - Abhishek Kumar On March 1, 2023, 10:03 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74331/ > ----------------------------------------------------------- > > (Updated March 1, 2023, 10:03 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4114 > https://issues.apache.org/jira/browse/RANGER-4114 > > > Repository: ranger > > > Description > ------- > > replaced references to "ranger.plugin." + serviceType with > pluginConfig.getPropertyPrefix() > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java > f65a0cf88 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 8f2ecaa1d > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java > a895e956a > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java > ef50b540e > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 5ebc4cfea > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineForDeltas.java > 4e1844bc6 > > > Diff: https://reviews.apache.org/r/74331/diff/1/ > > > Testing > ------- > > - verified that all unit tests pass successfully > - verified that HDFS/Hive/HBase/Kafka/YARN plugins successfully download > policies and tags > > > Thanks, > > Madhan Neethiraj > >
