----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74342/#review225262 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java Line 366 (original), 368 (patched) <https://reviews.apache.org/r/74342/#comment313981> Instead retrieving all columns (*), consider retrieving only column (banner): query ="SELECT banner FROM v$version WHERE rownum<2"; dbVersion = (String) getEntityManager().createNativeQuery(query).getSingleResult(); - Madhan Neethiraj On March 9, 2023, 3:40 a.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74342/ > ----------------------------------------------------------- > > (Updated March 9, 2023, 3:40 a.m.) > > > Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan > Periasamy. > > > Bugs: RANGER-4126 > https://issues.apache.org/jira/browse/RANGER-4126 > > > Repository: ranger > > > Description > ------- > > The `getDBVersion` function in `BaseDao` in the security-admin-web module > throws exception even for successful query execution for Oracle DB since it > tries to cast an Array of Objects to a String. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 418557bcb > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 8a13a1712 > > > Diff: https://reviews.apache.org/r/74342/diff/1/ > > > Testing > ------- > > Tested with Oracle DB and works fine > > > Thanks, > > Ramachandran Krishnan > >
